BUG: head and tail not dropping groups with nan #45102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 29, 2021
doc/source/whatsnew/v1.4.0.rst
Outdated
| @@ -894,6 +894,7 @@ Groupby/resample/rolling | |||
| - Bug in :meth:`GroupBy.nth` failing on ``axis=1`` (:issue:`43926`) | |||
| - Fixed bug in :meth:`Series.rolling` and :meth:`DataFrame.rolling` not respecting right bound on centered datetime-like windows, if the index contain duplicates (:issue:`3944`) | |||
| - Bug in :meth:`Series.rolling` and :meth:`DataFrame.rolling` when using a :class:`pandas.api.indexers.BaseIndexer` subclass that returned unequal start and end arrays would segfault instead of raising a ``ValueError`` (:issue:`44470`) | |||
| - Bug in :meth:`GroupBy.head` and :meth:`GroupBy.tail` no dropping groups with ``NaN`` when ``dropna=True`` (:issue:`45089`) | |||
|
|
||
| result = df.groupby(["X", "Y"]).tail(n=1) | ||
| tm.assert_frame_equal(result, expected) | ||
|
|
There was a problem hiding this comment.
can you test nth here as well
what does this mean |
|
Adjusting the mask for the dropna flag in a dedicated function, because the place I put this is a bit awkward |
jreback
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could also create a specific function for this.
Also that nth respects
as_indexwhile it is ignored byheadandtaillooks inconsistent